- 
                Notifications
    You must be signed in to change notification settings 
- Fork 8
Fix: Different startup steps implementation since other fix fails to restore #622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            BenjaminMichaelis
  merged 16 commits into
  IntelliTect:main
from
Joshua-Lester3:StartupSteps
  
      
      
   
  Nov 1, 2024 
      
    
                
     Merged
            
            Fix: Different startup steps implementation since other fix fails to restore #622
                    BenjaminMichaelis
  merged 16 commits into
  IntelliTect:main
from
Joshua-Lester3:StartupSteps
  
      
      
   
  Nov 1, 2024 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | Restores on my machine - not quite sure why the runner isn't able to. | 
af1c1dd    to
    23a3880      
    Compare
  
    59761da    to
    d283805      
    Compare
  
    
              
                    Keboo
  
              
              approved these changes
              
                  
                    Nov 1, 2024 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

    
  Joshua-Lester3 
      added a commit
        to Joshua-Lester3/EssentialCSharp.Web
      that referenced
      this pull request
    
      Dec 4, 2024 
    
    
      
  
    
      
    
  
…restore (IntelliTect#622) ## Description Pull Request IntelliTect#601 implementation fails to restore. I believe I narrowed the problem down to the added `disabledPackageSources` property in nuget.config, though my access to the Nuget feed isn't currently working. This solution takes the disabling effect out of nuget.config and puts it in the Directory.Packages.props. In the .props file it conditionally restores the private Nuget feed based on the single bool prop, `AccessToNugetFeed`, defined in Directory.Build.props. Credit: [GitHub issue 1](NuGet/Home#6045), [GitHub issue 2](NuGet/Home#3972) --------- Co-authored-by: Benjamin Michaelis <[email protected]>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
Pull Request #601 implementation fails to restore. I believe I narrowed the problem down to the added
disabledPackageSourcesproperty in nuget.config, though my access to the Nuget feed isn't currently working.This solution takes the disabling effect out of nuget.config and puts it in the Directory.Packages.props. In the .props file it conditionally restores the private Nuget feed based on the single bool prop,
AccessToNugetFeed, defined in Directory.Build.props.Credit: GitHub issue 1, GitHub issue 2